-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http exception cookies support #5197
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5197 +/- ##
==========================================
- Coverage 97.56% 97.54% -0.02%
==========================================
Files 43 43
Lines 8779 8794 +15
Branches 1412 1413 +1
==========================================
+ Hits 8565 8578 +13
- Misses 100 101 +1
- Partials 114 115 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@asvetlov if this approach is OK, I will update the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Could you please update web_excetions.rst to reflect new methods?
What |
4.0 |
That was exactly the reason why I've raised my question. If it doesn't break the API from 3.x in theory it can be backported to 3.x. |
Dropping the inheritance from While we keep the inheritance -- there Is no need to backport this PR because |
Thanks! |
This is a limited backport of aio-libs#5197 and aio-libs#3462
This is a limited backport of aio-libs#5197 and aio-libs#3462
What do these changes do?
Add methods
set_cookie()
andel_cookie()
toHTTPException
Add
cookies
property toHTTPException
Are there changes in behavior for the user?
User can set the cookies for
HTTPException
Related issue number
#4277
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.