[3.5] Allow run_app(access_log=None) (#3504) #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Mark access_log as optional * Make access_log=None work in debug mode (cherry picked from commit c562ffe) Co-authored-by: Hynek Schlawack <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 3.5 #3510 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 44 44
Lines 8565 8565
Branches 1382 1382
=======================================
Hits 8387 8387
Misses 72 72
Partials 106 106
Continue to review full report at Codecov.
|
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark access_log as optional
Make access_log=None work in debug mode
(cherry picked from commit c562ffe)
Co-authored-by: Hynek Schlawack [email protected]