Simplify HTTP pipelining implementation #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP pipelining is still supported but implemented as a simple FIFO queue with just 1 asyncio task attending it. It might allow optimize infrastructures based on microservices that do not use HTTP pipelining
fafhrd91
reviewed
Dec 25, 2017
Codecov Report
@@ Coverage Diff @@
## master #2623 +/- ##
==========================================
+ Coverage 97.91% 97.92% +<.01%
==========================================
Files 38 38
Lines 7331 7265 -66
Branches 1275 1259 -16
==========================================
- Hits 7178 7114 -64
+ Misses 49 47 -2
Partials 104 104
Continue to review full report at Codecov.
|
|
it is up to you, I'd remove StreamWriter at the same time |
asvetlov
approved these changes
Dec 26, 2017
|
I prefer two steps: the PR is huge already. |
|
Thanks, @pfreixes |
pfreixes
added a commit
that referenced
this pull request
Jan 10, 2018
Legacy StreamWriter as a pure proxy of the transport and the protocol is no longer needed. All of the functionalities that were behind this class has been moved to the PayloadWriter. Some changes that have to be considered that impacted during this change * TCP Operations have been isolated in a module rather than move them into the PayloadWriter * WebSocketWriter had a dependency with the StreamWriter, to get rid of that dependency the constructor has been modified to take the protocol and the transport. A next step changing the name PayLoadWriter for the StreamWriter to have consistency with the reader part, might be considered.
4 tasks
asvetlov
pushed a commit
that referenced
this pull request
Jan 11, 2018
* Get rid of legacy StreamWriter (#2623) Legacy StreamWriter as a pure proxy of the transport and the protocol is no longer needed. All of the functionalities that were behind this class has been moved to the PayloadWriter. Some changes that have to be considered that impacted during this change * TCP Operations have been isolated in a module rather than move them into the PayloadWriter * WebSocketWriter had a dependency with the StreamWriter, to get rid of that dependency the constructor has been modified to take the protocol and the transport. A next step changing the name PayLoadWriter for the StreamWriter to have consistency with the reader part, might be considered. * Add CHANGES * Fixed invalid import order * Fix test broken * Fix tcp_cork issues * Test PayloadWriter properties * Avoid return useless values for tcp_<operations> * Increase coverage http_writer * Increase coverage web_protocol
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
HTTP pipelining is still supported but implemented
as a simple FIFO queue with just 1 Asyncio task attending
it. It might allow optimizing infrastructures based on microservices
that do not use HTTP pipelining.
Are there changes in behavior for the user?
No
Related issue number
#2109