Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 304 benchmark for FileResponse #10114

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Add 304 benchmark for FileResponse #10114

merged 2 commits into from
Dec 5, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 5, 2024

related issue #10112
related comment #8013 (comment)
needed to prove out #10113

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Dec 5, 2024
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #10114 will not alter performance

Comparing add_304_benchmark (979453d) with master (84bb77d)

Summary

✅ 46 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark master add_304_benchmark Change
🆕 test_simple_web_file_response_not_modified[pyloop] N/A 67.8 ms N/A

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (84bb77d) to head (979453d).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10114   +/-   ##
=======================================
  Coverage   98.75%   98.76%           
=======================================
  Files         122      122           
  Lines       36927    36952   +25     
  Branches     4409     4411    +2     
=======================================
+ Hits        36469    36494   +25     
  Misses        311      311           
  Partials      147      147           
Flag Coverage Δ
CI-GHA 98.64% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.33% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.18% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.44% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.28% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.87% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.86% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.33% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.38% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.19% <100.00%> (+<0.01%) ⬆️
Py-3.13.1 98.35% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.19% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.73% <100.00%> (-0.05%) ⬇️
Py-pypy7.3.16 97.34% <100.00%> (-0.01%) ⬇️
VM-macos 97.44% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.33% <100.00%> (+<0.01%) ⬆️
VM-windows 96.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review December 5, 2024 15:33
@bdraco bdraco requested a review from asvetlov as a code owner December 5, 2024 15:33
@bdraco bdraco enabled auto-merge (squash) December 5, 2024 15:34
@bdraco bdraco merged commit 9456955 into master Dec 5, 2024
38 checks passed
@bdraco bdraco deleted the add_304_benchmark branch December 5, 2024 15:37
Copy link
Contributor

patchback bot commented Dec 5, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/9456955401cb8e78c363a92d829d924ef87bd004/pr-10114

Backported as #10115

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 5, 2024
Copy link
Contributor

patchback bot commented Dec 5, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/9456955401cb8e78c363a92d829d924ef87bd004/pr-10114

Backported as #10116

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 5, 2024
bdraco added a commit that referenced this pull request Dec 5, 2024
bdraco added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant