-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of parsing headers #10073
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10073 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 121 121
Lines 36860 36860
Branches 4396 4396
=======================================
Hits 36403 36403
Misses 311 311
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10073 will not alter performanceComparing Summary
|
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10083 🤖 @patchback |
(cherry picked from commit 349b756)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10084 🤖 @patchback |
(cherry picked from commit 349b756)
…aders (#10083) Co-authored-by: J. Nick Koston <[email protected]>
…aders (#10084) Co-authored-by: J. Nick Koston <[email protected]>
After we have a complete header we always have to convert it to a new bytes object. For almost every case we get the header in a single read. In this case its much faster to convert to bytes once. If the header gets split across multiple reads it will be a bit slower but this is the uncommon case.