This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Avoid deprecation warnings due to legacy __aiter__ protocol. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.34% (diff: 50.00%)@@ master #192 diff @@
==========================================
Files 55 55
Lines 7169 7177 +8
Methods 0 0
Messages 0 0
Branches 583 585 +2
==========================================
- Hits 6846 6843 -3
- Misses 237 243 +6
- Partials 86 91 +5
|
|
Sorry for the decreased coverage, but in fact all new lines are covered by the tests (but not in the same version of Python). |
…t commit, but without decreasing coverage).
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Python 3.5.2 the coroutine
__aiter__functions will throw PendingDeprecationWarnings. Starting with Python 3.6 it will be actual DeprecationWarnings.See https://www.python.org/dev/peps/pep-0492/#api-design-and-implementation-revisions