Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add support for Path type to the repo attribute of the Run class #2582

Merged
merged 3 commits into from
Mar 15, 2023
Merged

[feat] Add support for Path type to the repo attribute of the Run class #2582

merged 3 commits into from
Mar 15, 2023

Conversation

emekaokoli19
Copy link
Contributor

#2520 @tmynn @alberttorosyan could you please take a look at this

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@alberttorosyan
Copy link
Member

Hey @emekaokoli19! Thanks for your contribution. Will look into changes shortly.

alberttorosyan
alberttorosyan approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@alberttorosyan alberttorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alberttorosyan
Copy link
Member

@emekaokoli19 could you please update the CHANGELOG.md as well?

@alberttorosyan alberttorosyan changed the title [Feat] Add support for Path type to the repo attribute of the Run class [feat] Add support for Path type to the repo attribute of the Run class Mar 13, 2023
@emekaokoli19
Copy link
Contributor Author

@emekaokoli19 could you please update the CHANGELOG.md as well?

Just updated it

alberttorosyan
alberttorosyan approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@alberttorosyan alberttorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alberttorosyan alberttorosyan merged commit 07648bb into aimhubio:main Mar 15, 2023
@emekaokoli19 emekaokoli19 deleted the pathlib.Path branch March 15, 2023 18:58
@bsridatta bsridatta mentioned this pull request Apr 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alberttorosyan alberttorosyan alberttorosyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emekaokoli19 @CLAassistant @alberttorosyan