Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Tensorboard convert while converting tensor #2000

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

Sharathmk99
Copy link
Contributor

Fixes #1995

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2022

CLA assistant check
All committers have signed the CLA.

@Sharathmk99 Sharathmk99 force-pushed the bugfix/tensorbord-convert branch from 614659d to fcb9cdc Compare July 26, 2022 12:50
@gorarakelyan
Copy link
Contributor

@Sharathmk99 thanks for the contribution! Will review it asap.
Meanwhile, could you please mention the addition in the changelog?

Copy link
Member

@alberttorosyan alberttorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🙌
@Sharathmk99 please include the fix in CHANGELOG.md so I can approve this PR

@Sharathmk99 Sharathmk99 changed the title [fix] tensorboard convert while converting tensor [fix] Tensorboard convert while converting tensor Jul 27, 2022
@Sharathmk99
Copy link
Contributor Author

looks great 🙌 @Sharathmk99 please include the fix in CHANGELOG.md so I can approve this PR

Updated CHANGELOG.md Many thanks

@gorarakelyan gorarakelyan self-requested a review July 28, 2022 17:21
@gorarakelyan gorarakelyan merged commit 05c17d5 into aimhubio:main Jul 29, 2022
@gorarakelyan
Copy link
Contributor

@Sharathmk99 just merged the PR. Congrats on the first contribution! 🚀

@Sharathmk99
Copy link
Contributor Author

@Sharathmk99 just merged the PR. Congrats on the first contribution! 🚀

Thank you very much @gorarakelyan

@Sharathmk99 Sharathmk99 deleted the bugfix/tensorbord-convert branch July 29, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facing issue while converting tensorboard logs to Aim
4 participants