Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default number of cv_folds is changed to 5 #865

Merged
merged 4 commits into from
Sep 8, 2022
Merged

Conversation

andreygetmanov
Copy link
Collaborator

@andreygetmanov andreygetmanov commented Sep 6, 2022

Changed default cv_folds number in params for table data and in some tests

@pep8speaks
Copy link

pep8speaks commented Sep 6, 2022

Hello @andreygetmanov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-09-08 11:35:05 UTC

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #865 (62f4727) into master (6487966) will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
+ Coverage   87.56%   87.89%   +0.32%     
==========================================
  Files         196      196              
  Lines       13405    13405              
==========================================
+ Hits        11738    11782      +44     
+ Misses       1667     1623      -44     
Impacted Files Coverage Δ
...n/operation_implementations/models/custom_model.py 86.36% <0.00%> (-4.55%) ⬇️
...implementations/models/ts_implementations/naive.py 95.95% <0.00%> (-1.02%) ⬇️
...tations/data_operations/sklearn_transformations.py 88.73% <0.00%> (-0.94%) ⬇️
...entations/models/ts_implementations/statsmodels.py 94.89% <0.00%> (+0.51%) ⬆️
...dot/core/optimisers/gp_comp/operators/crossover.py 88.46% <0.00%> (+0.96%) ⬆️
...lementations/data_operations/ts_transformations.py 88.10% <0.00%> (+11.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@valer1435 valer1435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Посмотри хотя бы в дебаге на всякий случай, что там теперь действительно 5 фолдов. А то мало ли

@andreygetmanov andreygetmanov reopened this Sep 8, 2022
@andreygetmanov andreygetmanov merged commit c8eed58 into master Sep 8, 2022
@andreygetmanov andreygetmanov deleted the cv_num_hotfix branch September 8, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants