Fix test_pipeline_fit_time_constraint #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicl-nno
reviewed
Apr 11, 2022
test/unit/pipelines/test_pipeline.py
Outdated
| @@ -391,7 +391,7 @@ def test_pipeline_fit_time_constraint(data_fixture, request): | |||
| computation_time_first = test_pipeline_first.computation_time | |||
| assert type(received_ex) is TimeoutError | |||
| comp_time_proc_with_first_constraint = (time.time() - process_start_time) | |||
| time_constraint = datetime.timedelta(seconds=2) | |||
| time_constraint = datetime.timedelta(seconds=3) | |||
| test_pipeline_first.unfit(unfit_preprocessor=True) | |||
There was a problem hiding this comment.
unfit перед повторными fit не нужен
There was a problem hiding this comment.
unfit перед повторными fit не нужен
Убрал
nicl-nno
approved these changes
Apr 11, 2022
andreygetmanov
force-pushed
the
fix_test_pipeline_fit_time_constraint
branch
from
c765a31 to
8fefc5a
Compare
Fixed occasional test error when computational time of pipeline with higher time constraint was lower than computational time with less time constraint
andreygetmanov
force-pushed
the
fix_test_pipeline_fit_time_constraint
branch
from
8fefc5a to
13793c2
Compare
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
==========================================
- Coverage 86.58% 86.55% -0.03%
==========================================
Files 153 153
Lines 11246 11246
==========================================
- Hits 9737 9734 -3
- Misses 1509 1512 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed occasional test error when computational time of pipeline with higher time constraint was lower than computational time with less time constraint
Time constraint affects fit time, but fit time also fluctuates because of internal hardware reasons. The dispersion of this fluctuation seems to be constant. Therefore, if fit process is optimized, the fit time of both time constraint values in test is reduced, but dispersion remains the same. This raises the probability of dispersions' overlay and, hence, the test fail. Change of timeouts to 1 and 5 seconds provides stable work of test