-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initial assumptions as list of pipelines #1070
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Возможно есть смысл в
fit_assumption_and_check_correctness
фитить все пайплайны изinitial_assumption
?Тогда не нужно будет делать разделение на
initial_assumption
иfitted_assumption
. И вcompose_pipeline
, если не хватает времени, возвращать в качествеbest_pipeline_candidates
initial_assumption
целиком. Ну и как будто если мы действительно весьinitial_assumption
передаем в оптимизатор, то нужно его весь проверить.Только надо будет оценку времени на assumption изменить, возможно, взять как среднее время фита для паплайна.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут смысл в том, что fit_assumption_and_check_correctness обучает на полных данных, без CV. Поэтому дальше эти результаты можно использовать только если итоговый пайплайн совпадает с ним по структере.
Так что особо смысла обучать все нет.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YamLyubov, значит, можем вливать?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Насколько я понимаю, оптимизатор не сломается, если часть индивидов будут "поломаные", — тогда они просто тут же "вымрут". Верно?
Для единственного начального приближения более критично быть работоспособным.
Конечно, ещё можем тут в цикле проверять начальные приближения до первого успешного. В редких случаях это отнимет много времени у эволюции, но это не должно возникать часто. Зато, если пользователь предоставил несколько начальных приближений, часть из которых нерабочие, Федот не сломается.