Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORM: add EnumData plugin to to_aiida_type dispatch #5314

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jan 17, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #5314 (29fd4cf) into develop (d9f8c85) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5314      +/-   ##
===========================================
+ Coverage    82.02%   82.02%   +0.01%     
===========================================
  Files          533      533              
  Lines        38255    38259       +4     
===========================================
+ Hits         31373    31377       +4     
  Misses        6882     6882              
Flag Coverage Δ
django 77.07% <100.00%> (-<0.01%) ⬇️
sqlalchemy 76.34% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/orm/nodes/data/enum.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f8c85...29fd4cf. Read the comment docs.

@sphuber sphuber requested a review from mbercx January 19, 2022 13:01
Copy link
Member

@mbercx mbercx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for giving me a reason to find out what a single dispatch generic function is. :)

@sphuber sphuber merged commit 44577af into aiidateam:develop Jan 19, 2022
@sphuber sphuber deleted the fix/enum-to-aiida-type branch January 19, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants