Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOCS: Add example for retrieve_temporary_list #5157

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Oct 3, 2021

Fixes #5143

The current section on how the user can retrieve files temporarily to use
during parsing doesn't contain any examples on how to use this feature. Here
we add an example on how to specify the list of files to be retrieved in a
temporary folder, clearly showing the retrieve_temporary_list attribute of
the CalcInfo. We also add an example of how to obtain the
retrieved_temporary_folder from the kwargs of the Parser.parse() method.

@mbercx mbercx requested review from chrisjsewell and sphuber October 3, 2021 19:48
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbercx just a small suggestion to add and then this can be merged

docs/source/topics/calculations/usage.rst Show resolved Hide resolved
@mbercx
Copy link
Member Author

mbercx commented Oct 4, 2021

Thanks for the review, @sphuber! I've added an "important" note on the type of the kwargs['retrieved_temporary_folder']. Re the suggestion of making this a pathlib.Path instead, I agree 👍 .

mbercx added 2 commits October 4, 2021 20:06
The current section on how the user can retrieve files temporarily to use
during parsing doesn't contain any examples on how to use this feature. Here
we add an example on how to specify the list of files to be retrieved in a
temporary folder, clearly showing the `retrieve_temporary_list` attribute of
the `CalcInfo`. We also add an example of how to obtain the
`retrieved_temporary_folder` from the `kwargs` of the `Parser.parse()` method.
@mbercx mbercx force-pushed the docs/5143/retrieve-temp branch from ce9da09 to 61c2ac6 Compare October 4, 2021 18:06
@mbercx
Copy link
Member Author

mbercx commented Oct 4, 2021

@sphuber sphuber merged commit b1773f8 into aiidateam:develop Oct 4, 2021
@mbercx mbercx deleted the docs/5143/retrieve-temp branch October 4, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: complete section on retrieve_temporary_list
2 participants