Refactor tests #442
Merged
Refactor tests #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
force-pushed
the
refactor-tests
branch
from
83a74d2 to
9c94945
Compare
|
@unkcpz this one is ready for review, LMK if you'll have a time to have a look (or perhaps nominate another reviewer?) |
unkcpz
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Thanks @danielhollas, changes are all clear and looks all good.
danielhollas
added a commit
that referenced
this pull request
Apr 17, 2024
Currently, one has to manually pass in test files for tests for various image variants (targets). Here we automatically skip all tests that are not intended to pass for a given image. Note that there is a behavioural change: Previously, for e.g. lab variant, we would only run test-common.py and test-lab.py. Now we also test it against test-base.py, since all images should pass all the tests for the lower layers as well. full-stack should pass all tests. * Use ruff formatter and linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, one has to manually pass in test files for tests for various image variants (targets). That's not very elegant; instead here we automatically skip all tests that are not intended to pass for a given image.
Note that there is a behavioural change: Previously, for e.g.
labvariant, we would only runtest-common.pyandtest-lab.py. But now we also test it againsttest-base.py. All images should pass all the tests for the lower layers as well.full-stackshould pass all tests.Also switched from black to ruff and added basic lint rules to help with writing tests.