[Refactor] move A2C in separate folder for clarity #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
|
Not a high priority for the moment. We can keep this PR as a template in case we want to make A2C methods clearer in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move Critic from REINFORCE to A2C
Motivation and Context
It may be confusing for some to see "critic" as a baseline for REINFORCE when, indeed, it is equal to A2C. This is a way to make it easier for newcomers to grasp some concepts.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist