Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline some helper functions in driver #372

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Inline some helper functions in driver #372

merged 1 commit into from
Nov 3, 2022

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Nov 2, 2022 •
edited
Loading

Purpose

This PR makes small cleanups in driver before presenting it to GFDL

Code changes:

  • Inlined driver._step_dynamics and driver._step_physcs
  • Made driver methods update_driver_with_communicator and end_of_step_actions private

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

@mcgibbon mcgibbon marked this pull request as ready for review November 2, 2022 21:06
@mcgibbon mcgibbon merged commit 76fcff8 into main Nov 3, 2022
@mcgibbon mcgibbon deleted the feature/small_driver_refactors branch November 3, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elynnwu elynnwu elynnwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcgibbon @elynnwu