Convert storage temporaries in fv3core to Quantity #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elynnwu
reviewed
Oct 26, 2022
| "current implementation requires damp_c and nord to have " | ||
| "identical data shape and dims" | ||
| ) | ||
| data = (damp_c.data * da_min) ** (nord.data + 1) |
There was a problem hiding this comment.
Why is this moved away from gt4py stencil?
There was a problem hiding this comment.
Are all the removed stencils because it's called once in init only?
There was a problem hiding this comment.
Yes. I removed the gt4py stencils done for computing 1D values to avoid adding more complexity to the already complex make-a-3d-storage-to-compute-to-subset-into-a-1d-storage logic.
|
launch jenkins |
elynnwu
reviewed
Nov 2, 2022
There was a problem hiding this comment.
Built dace orchestration on this PR, build completed, but run has the following errors:
Traceback (most recent call last):
File "_ctypes/callbacks.c", line 237, in 'calling callback function'
File "/scratch/snx3000/ewu/sandbox/check_dace_orch/pace/venv/lib/python3.8/site-packages/pace/util/_timing.py", line 82, in __enter__
self.timer.start(name)
File "/scratch/snx3000/ewu/sandbox/check_dace_orch/pace/venv/lib/python3.8/site-packages/pace/util/_timing.py", line 28, in start
raise ValueError(f"clock already started for '{name}'")
ValueError: clock already started for 'Remapping'
...
Traceback (most recent call last):
File "_ctypes/callbacks.c", line 237, in 'calling callback function'
File "/scratch/snx3000/ewu/sandbox/check_dace_orch/pace/venv/lib/python3.8/site-packages/dace/dtypes.py", line 1031, in trampoline
return orig_function(*list_of_other_inputs)
File "/scratch/snx3000/ewu/sandbox/check_dace_orch/pace/venv/lib/python3.8/site-packages/pace/util/_timing.py", line 86, in __exit__
self.timer.stop(name)
File "/scratch/snx3000/ewu/sandbox/check_dace_orch/pace/venv/lib/python3.8/site-packages/pace/util/_timing.py", line 43, in stop
self._accumulated_time[name] += time() - self._clock_starts.pop(name)
KeyError: 'mainloop'
elynnwu
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes to gt4py will soon allow custom classes to be used in place of storages. We'd like to take advantage of this by using Quantity everywhere in the model. This PR refactors all internal temporaries in fv3core to use Quantity.
Code changes:
Checklist
Before submitting this PR, please make sure:
pace-util, HISTORY has been updated