Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize column integral calculation #350

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Optimize column integral calculation #350

merged 4 commits into from
Oct 12, 2022

Conversation

elynnwu
Copy link
Collaborator

@elynnwu elynnwu commented Oct 4, 2022 •
edited
Loading

Purpose

This PR makes the calculation of column integrated tracers faster.

Code changes:

  • diagnostics: use quantity np sum instead of native python sum

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

@elynnwu elynnwu requested a review from jdahm October 12, 2022 17:13
@elynnwu elynnwu enabled auto-merge (squash) October 12, 2022 22:29
jdahm
jdahm approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@jdahm jdahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@elynnwu elynnwu merged commit 4c5b18d into main Oct 12, 2022
@elynnwu elynnwu deleted the fix/column-integral-opt branch October 12, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcgibbon mcgibbon mcgibbon left review comments

@jdahm jdahm jdahm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elynnwu @jdahm @mcgibbon