Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix driver caching on daint #348

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Fix driver caching on daint #348

merged 5 commits into from
Sep 28, 2022

Conversation

elynnwu
Copy link
Collaborator

@elynnwu elynnwu commented Sep 27, 2022 •
edited
Loading

Purpose

This PR fixes driver caching on jenkins.

Code changes:

  • jenkins.sh: fetch driver caches to top directory
  • pace_physics_cache_setup.sh: add driver translate test and save caches

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

@elynnwu
Copy link
Collaborator Author

elynnwu commented Sep 28, 2022

launch jenkins

1 similar comment
@elynnwu
Copy link
Collaborator Author

elynnwu commented Sep 28, 2022

launch jenkins

jdahm
jdahm approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@jdahm jdahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@elynnwu elynnwu enabled auto-merge (squash) September 28, 2022 20:38
@elynnwu elynnwu merged commit f6a3186 into main Sep 28, 2022
@elynnwu elynnwu deleted the fix/driver-caching branch September 28, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdahm jdahm jdahm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elynnwu @jdahm