Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tc init #346

Merged
merged 140 commits into from
Dec 14, 2022
Merged

Feature/tc init #346

merged 140 commits into from
Dec 14, 2022

Conversation

ajdas1
Copy link
Contributor

@ajdas1 ajdas1 commented Sep 23, 2022

Purpose

Creating an initialization for the tropical cyclone case (following the example of how the baroclinic init was set up).
It doesn't quite work all the way.
I believe that the initial fortran state is set correctly - when I compare it to the fortran restart files written out 1 second after restart, everything is identical except for small changes in winds.
But after 1 time step, all fields are set to nan.
I didn't have quite enough time to figure out why and how to fix it.

Code changes:

  • Just added code, didn't change existing code.

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

Additionally, if this PR contains code authored by new contributors:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@elynnwu elynnwu changed the base branch from main to feature/fortran_restart September 26, 2022 18:49
Base automatically changed from feature/fortran_restart to main October 19, 2022 00:53
@FlorianDeconinck
Copy link
Contributor

Reverting the PR to inject only the WIP TC init code. All other changes to restart work has been removed.

@FlorianDeconinck FlorianDeconinck merged commit 119912d into main Dec 14, 2022
@FlorianDeconinck FlorianDeconinck deleted the feature/tc_init branch December 14, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants