Checkpointer validates on C_SW and D_SW #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgibbon
reviewed
Sep 9, 2022
| @@ -691,7 +691,7 @@ def _checkpoint_dsw_in(self, state: DycoreState): | |||
| ucd=state.uc, | |||
| vcd=state.vc, | |||
| wd=state.w, | |||
| delpcd=self.delpc, | |||
| delpcd=self._vt, | |||
There was a problem hiding this comment.
It is wild to me that delpc is still a temporary but it's not the variable in the savepoint.
There was a problem hiding this comment.
Should we add some # commenting about this? It's very confusing.
mcgibbon
reviewed
Sep 9, 2022
mcgibbon
requested changes
Sep 12, 2022
| @@ -691,7 +691,7 @@ def _checkpoint_dsw_in(self, state: DycoreState): | |||
| ucd=state.uc, | |||
| vcd=state.vc, | |||
| wd=state.w, | |||
| delpcd=self.delpc, | |||
| delpcd=self._vt, | |||
There was a problem hiding this comment.
Should we add some # commenting about this? It's very confusing.
elynnwu
changed the title
elynnwu
changed the title
|
launch jenkins |
|
launch jenkins |
2 similar comments
|
launch jenkins |
|
launch jenkins |
|
I approve of merging without the driver_savepoints_mpi-gt:cpu_ifirst plan, which is currently having some issues and might need a larger resource type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In this PR, checkpointers are passing at
FVDynamics-In,C_SW-In/Out,D_SW-In/Out, and failing onqvaporwith small error inFVDynamics-Out(passing on all other variables) with the automatically calibrated thresholds. Further investigation is needed.Additionally, in Fortran serialized data,
FVDynamics-Outhas filled values in the halos for tracers. Instead of subsetting them, we do not serialize them out in the latest8.1.2dataset.Code changes:
dyn_core: fixed a mistake in the variables being passed toFVDynamics-Incheckpointertranslate_fvdynamics/driver: we do not subset tracers since they are cropped in the serialized datatest_translate: skip subsetting tracers when TrueChecklist
pace-util, HISTORY has been updated