Fix code scanning alert no. 10: Incomplete URL substring sanitization

[PeterDaveHello]

Fixes https://github.com/ai-shifu/ChatALL/security/code-scanning/10

To fix the problem, we need to ensure that the domain check is robust and cannot be bypassed by embedding the allowed host in unexpected locations. The best way to achieve this is by using a whitelist of allowed domains and performing an exact match against the parsed host of the URL.

1. Parse the cookie domain to extract the host.
2. Use a whitelist of allowed domains to check if the parsed host matches any of the allowed domains.
3. Update the code to use this secure method for domain validation.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Summary by CodeRabbit

• New Features

  • Introduced a streamlined method for checking allowed domains.

• Bug Fixes

  • Simplified cookie expiration logic for better maintainability.

• Refactor

  • Improved code clarity and efficiency in domain checks and cookie handling, including enhanced error handling for domain validation.

[coderabbitai]

Walkthrough

The changes in this pull request enhance the src/background.js file by introducing a new constant allowedDomains, which contains a list of permitted domains. A new function, isAllowedDomain, is added to centralize the logic for checking if a given domain is in the allowedDomains list, replacing previous inline checks in the cookie handling logic. The cookie management is updated to utilize isAllowedDomain, and error handling is incorporated to address potential parsing issues. The overall structure and functionality of the application remain unchanged, with no new public entities introduced.

Changes

File	Change Summary
src/background.js	Added const allowedDomains for permitted domains; added isAllowedDomain function for domain checks; updated cookie management to use this function; added error handling for domain parsing.

Poem

In the code where rabbits play,
New functions hop and dance today.
Domains checked with ease and grace,
Cookies managed in their place.
Hooray for changes, bright and new,
A cleaner path for us to pursue! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3be84ad and d30570c.

📒 Files selected for processing (1)

• src/background.js (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/background.js

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[PeterDaveHello]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 92348a5 and ec7b9a2.

📒 Files selected for processing (1)

• src/background.js (3 hunks)

🧰 Additional context used

🔇 Additional comments (1)

src/background.js (1)

196-196: Appropriate use of isAllowedDomain in cookie handling

The use of isAllowedDomain(cookie.domain) effectively ensures that the cookie expiration date is set only for cookies from allowed domains, enhancing security by controlling cookie lifespans appropriately.

[PeterDaveHello]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/background.js (1)

207-217: Well-implemented domain validation function

The isAllowedDomain function is correctly implemented and follows best practices:

• It handles domains with or without a leading dot.
• Uses the URL API for robust parsing.
• Checks for both exact matches and subdomains.

Consider a minor optimization:

 function isAllowedDomain(domain) {
   const allowedDomains = [
     "aliyun.com",
     "qianwen.aliyun.com"
   ];
-  const parsedHost = new URL(`https://${domain.startsWith(".") ? domain.substring(1) : domain}`).host;
+  const parsedHost = new URL(`https://${domain.replace(/^\./, '')}`).host;
   return allowedDomains.some(
     (allowedDomain) =>
       parsedHost === allowedDomain || parsedHost.endsWith(`.${allowedDomain}`)
   );
 }

This change simplifies the domain parsing logic using a regular expression, making it slightly more concise and easier to read.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ec7b9a2 and 54fbeec.

📒 Files selected for processing (1)

• src/background.js (2 hunks)

🧰 Additional context used

🔇 Additional comments (2)

src/background.js (2)

195-197: Improved domain check logic

The replacement of hardcoded domain checks with the isAllowedDomain function enhances code maintainability and flexibility. This change centralizes domain validation logic, making it easier to update the list of allowed domains in the future.

---

Line range hint 518-522: Correct implementation of cookie expiration date calculation

The setCookieExpireDate function correctly calculates the cookie expiration date:

• It uses the provided number of days to set the future date.
• Returns the expiration date in seconds since the epoch, which is the correct format for cookie expiration.

The implementation is correct and follows best practices.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 54fbeec and 969ee65.

📒 Files selected for processing (1)

• src/background.js (2 hunks)

🧰 Additional context used

[PeterDaveHello]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.