-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plz #46
Plz #46
Conversation
I'm happy to see this go in, thank you! Next step, I think, is to make sure the emacs-devel list is fine with your plan to eventually release the various handles you have as a separate GNU ELPA package, specifically for |
Hi @ahyatt, the ELPA maintainers are fine with adding plz-media-type and plz-event-source to ELPA. We actually have it already: Once we are fine everything works as expected with the vendored libraries we can remove the Roman |
Excellent, thank you! Can these be required via |
No, until they are released they should not be added to the package-requires section, otherwise tools might try to install the libraries from some package archive and fail. |
I am still not seeing your packages in GNU ELPA. Do you know what is going on with that? |
Hi @ahyatt, Philip added both libraries into the ELPA Git repository 2 weeks ago. I put you on CC in this conversation. https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg00015.html They won't appear on the ELPA website until I remove the I'm still under the assumption that we ship plz-media-type and plz-event-source with the llm library initially and release them to ELPA once we are sure there aren't any serious flaws. The timeline being half a year, as we discussed. I'm using the plz branch of the llm library since 2 weeks now with the OpenAI and my custom OpenAI provider. I haven't noticed anything wrong. So those are good to go. Did you had the chance to test the other providers using the plz branch? What's the plan? |
Thanks, I did see that conversation, but forgot about the resolution. I need to resolve an issue with the llm version, and then I'll merge the |
Ok, cool. I'm looking forward to it! |
As far as I can see, both plz-media-type and plz-event-source are now available on GNU ELPA. Would you welcome a PR that un-vendors these packages? |
yes, I think we could unbundle them. I tagged the plz-media-type and plz-event-source libraries a while ago with a version and published them to ELPA, because I was using them also in another project. Nothing should have changed functionality wise from the bundled version we have in the llm library. So if you would like to do it @leotaku , please go ahead! Thanks, Roman. |
This PR aims to unvendor plz-event-source and plz-media-type. According to <#46 (comment)>, this should not cause any problems. I chose to define `0.1.0` as the minimum required versions, because the vendored packages are seemingly older, and it seems like established Elisp practice is to specify the "lowest version that is expected to reasonably function".
Hi @ahyatt,
we now have a release of plz: alphapapa/plz.el#50
It's not on ELPA yet, but I hope this is done by some cron job that runs eventually.
This PR removes the vendored plz.el and adds it to the package requires.