-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add revocation details #15
base: trust-anchor-sets
Are you sure you want to change the base?
Conversation
Signed-off-by: Monis Khan <[email protected]>
since it can easily cache certificate revocation lists. | ||
|
||
When the API server parses the bundles within `pemTrustAnchors`, it will extract | ||
out all `CRLDistributionPoints` that have a `http://` scheme. These CRLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any plan to support a HTTPS scheme? While generally CRLs are distributed by http (and that's safe as they're independently signed, though still prone to replay attacks), I've been discouraging my clients from allowing any outbound HTTP Connections from their cluster as a matter of security (not shooting themselves in the foot, really). On the other hand, introducing the HTTPS Scheme creates a whole minor issue of which trust bundle to use for that connection; Either the pemTrustAnchors or the system CA store could be appropriate in different circumstances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could support https but it does complicate the code for the reasons you mentioned. Technically we could just skip all TLS verification and rely on the same verification as we do for http. It would be equivalently secure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentionally setting insecureSkipVerify on CRL download clients is a good call ; want to add that to the spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was contentious so we have dropped the API server bits altogether for the 1.26 release.
434efb5
to
df35249
Compare
46cfe79
to
9b8216c
Compare
c66985d
to
f2c6f88
Compare
No description provided.