Add WOFF2 format for icon format and change font references in CSS #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated the WOFF2 version via this generator - https://everythingfonts.com/woff-to-woff2
Removed the query parameter strings from font file references. This issue on FontAwesome better explains this - FortAwesome/Font-Awesome#3286
The order in which fonts are specified effects which font would get loaded by the browser(aka if WOFF gets specified before WOFF2, then the browser will end up loading that), Refer to - https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/webfont-optimization#format_selection