Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AJV to version 6 #109

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Update AJV to version 6 #109

merged 1 commit into from
Nov 7, 2018

Conversation

realityking
Copy link
Contributor

@realityking realityking commented Jul 1, 2018

Fixes #107, closes #105

@realityking
Copy link
Contributor Author

realityking commented Jul 1, 2018

I hadn't realized that a dependency of ajv has dropped support for Node.js 4. I suspect that's not an option for har-validator, is it?

@danepowell
Copy link

danepowell commented Aug 25, 2018

I'd really love to see AJV updated, because a lot of other packages (such as Request) depend on har-validator, and this in turn creates ugly version conflicts.

For instance, the Parse library requires Request requires Har Validator requires ajv 5. Eslint requires Table requires AJV 6.

Trying to use Parse and Eslint on the same project produces warnings about peer dependency conflicts, Parse can't find ajv at runtime, and everything falls over. Blech.

Obviously it's not my decision to make, but Node.js 4 was end of life some time ago, it seems pretty reasonable to me to drop support.

@philihp
Copy link

philihp commented Oct 31, 2018

Would love to see this merged, although it would warrant a major version bump.

Jest also requires Request which requires Har-Validator which requires Ajv 5.

@ahmadnassri ahmadnassri merged commit 759bffe into ahmadnassri:master Nov 7, 2018
@ahmadnassri
Copy link
Owner

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ahmadnassri ahmadnassri added the released This change has been released label Nov 7, 2018
@realityking realityking deleted the ajv branch November 8, 2018 16:21
@epoberezkin
Copy link
Contributor

@ahmadnassri it is probably worth updating schemas in har-schema to use draft-07 (as it's backwards compatible, it only requires changing $schema) - then these 2 lines can be removed:
https://github.com/ahmadnassri/node-har-validator/pull/109/files#diff-688ede0ee2da1fa3d89f2fc485f39273R11
https://github.com/ahmadnassri/node-har-validator/pull/109/files#diff-6230eb7fbf1dd2186bf1be6042c27f55R11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This change has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with packaging
5 participants