Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop CALL_API alias #193

Merged
merged 1 commit into from
Jun 10, 2018
Merged

Drop CALL_API alias #193

merged 1 commit into from
Jun 10, 2018

Conversation

nason
Copy link
Collaborator

@nason nason commented Jun 10, 2018

  • 2.0 changed from CALL_API symbol to RSAA string, but we added a temporary alias
  • 3.0 will remove this alias

@nason
Drop CALL_API alias
e9c9527 
BREAKING CHANGE that is part of the 3.x release
@nason nason added this to the 3.0.0 milestone Jun 10, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e9c9527 on drop_call_api_alias into 750524f on next.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 10, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e9c9527 on drop_call_api_alias into 750524f on next.

@nason nason merged commit 7bb3961 into next Jun 10, 2018
@nason nason deleted the drop_call_api_alias branch July 14, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking Change
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nason @coveralls