Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oracle): github issue/pr verificaiton logic #8

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

0xpatrickdev
Copy link
Collaborator

@0xpatrickdev 0xpatrickdev commented Nov 16, 2023

image image

@dckc
Copy link
Collaborator

dckc commented Nov 16, 2023

typo: verificaiton
mostly as evidence that I'm reading closely :)

Comment on lines +102 to +107
assignees (first:1) {
nodes {
resourcePath
name
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no url for assignees?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resourcePath is /${username}, so this was easier to parse

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we use id. There may be a way to get it via a relation but didn't did too hard

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm. if we use url for both PR author and issue assignee, there's no need to parse anything, right?

onSuccess: (data) => {
// Handle success
console.log("success", data);
toast.success("Bounty claimed successfully!");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: listen for invitation, build tx, and prompt user to sign keplr tx

Copy link
Collaborator

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kicking the tires; it seems to work pretty well.

For example, I tried to claim based on one of your PRs, and I got:

image

{"level":30,"time":1700175686110,"pid":2988393,"hostname":"bldbox","reqId":"req-3","req":{"method":"POST","url":"/job/claim","hostname":"localhost:5000","remoteAddress":"127.0.0.1","remotePort":54794},"msg":"incoming request"}
{"level":30,"time":1700175686725,"pid":2988393,"hostname":"bldbox","reqId":"req-3","res":{"statusCode":403},"responseTime":614.2947220206261,"msg":"request completed"}

@0xpatrickdev 0xpatrickdev merged commit bb4303d into main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants