Skip to content

Commit

Permalink
net/mlx4_core: Fix VF overwrite of module param which disables DMFS o…
Browse files Browse the repository at this point in the history
…n new probed PFs

[ Upstream commit 95f1ba9 ]

In the VF driver, module parameter mlx4_log_num_mgm_entry_size was
mistakenly overwritten -- and in a manner which overrode the
device-managed flow steering option encoded in the parameter.

log_num_mgm_entry_size is a global module parameter which
affects all ConnectX-3 PFs installed on that host.
If a VF changes log_num_mgm_entry_size, this will affect all PFs
which are probed subsequent to the change (by disabling DMFS for
those PFs).

Fixes: 3c439b5 ("mlx4_core: Allow choosing flow steering mode")
Signed-off-by: Majd Dibbiny <[email protected]>
Reviewed-by: Jack Morgenstein <[email protected]>
Signed-off-by: Tariq Toukan <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
majdmellanox authored and gregkh committed Oct 21, 2017
1 parent 84a66ca commit 8909b26
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/ethernet/mellanox/mlx4/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -841,8 +841,6 @@ static int mlx4_slave_cap(struct mlx4_dev *dev)
return -ENOSYS;
}

mlx4_log_num_mgm_entry_size = hca_param.log_mc_entry_sz;

dev->caps.hca_core_clock = hca_param.hca_core_clock;

memset(&dev_cap, 0, sizeof(dev_cap));
Expand Down

0 comments on commit 8909b26

Please sign in to comment.