Fix project selector focus by targeting first selected element #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the project selector focus behavior by targeting the first selected element instead of all selected ones.
- Updates the focus logic on the project jump dropdown
- Targets only the first selected project for improved UX
Comments suppressed due to low confidence (1)
app/assets/javascripts/application.js:778
- The change updates the focusing behavior but lacks unit tests to verify that the first selected project is focused as expected. Please add tests to ensure this behavior works reliably.
selected.first().focus(); // Calling focus to scroll to selected project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redmine.orgのチケットURL: https://www.redmine.org/issues/xxxx
TODO: