Certain rotated Blockstates are not updating correctly.

[Tsoccerguy3]

I removed everything from the pack except the iron door . there was a change to packs a few versions ago that merged doors and although this would work in 1.16.5 , it does not work in 1.18.2 ,1.19

in 1.16.5 screenshot

in 1.19 screenshot

iron_door_resources_pack_converted.zip

[lowercasebtw]

Can you test this again or provide the pack?

[lowercasebtw]

oh wait you do provide the pack, im blind

[lowercasebtw]

why did you provide the converted one bruh,
can you provide the original?

[Tsoccerguy3]

www.mediafire.com/file/ppcpvu7xb5b0t6x/Witchcraft_and_Wizardry_-_Resource_Pack.zip/file

here is the full pack this is a advanced pack , making use of all features. note there is a top and bottom for doors.

[lowercasebtw]

ah alright

[Tsoccerguy3]

here is the map for that pack https://www.mediafire.com/file/ij0zqbumkjufv39/Witchcraft_and_Wizardry.zip/file

[lowercasebtw]

Where you on any sub version of 1.19? or Just 1.19.0?

[Tsoccerguy3]

The pack is in the map root to auto load . map is 1.16.5 only

[lowercasebtw]

But you loaded in 1.19? The issue says 1.16.5 to 1.19

[lowercasebtw]

Map says 1.16.3 in the worlds menu

[Tsoccerguy3]

I'm always updating . Now I'm working on updating the map to 1.20.4 . Yes its a 1.16.x map

[Tsoccerguy3]

I did manually fix errors by checking the minecraft logs . Theoretically can OPEN AI update software like minecraft stuff?

[lowercasebtw]

My game keep crashing when trying to use the pack, but from looking, the iron door models are missing in the models folder.

[Tsoccerguy3]

The map was made for 1.16.5 and is a adventure map with a interactive datapack and custom reasourcepack. If something is missing in the pack, then it inherits default from minecrafts built in reasourcepack..

To understand the project open the map in 1.16.5

here is some helpful cheats

instructions to test game play

You can do

/function hp:setup
/reset_game
/function hp:setup
/go_to_main_menu to start a new game

Start a game and then you can do /tag @s add e when the cutscene is done to exit
and /tag @s add play to reenter playmode

/trigger exploreMode
/trigger resetGame

This issue was opened a while ago , but lets say that we want to go from 1.16.x to 1.20.4 and above . More things have changed .

In 1.16.5 lets prepare the map for update to 1.20.4 , by putting the game in explore mode /trigger exploreMode . The game can now be upgraded to higher versions . Generally you would open the map in 1.19.2 and allow Minecraft to convert the area around the player, then close the game and open in 1.20.4 . You are still in explore mode but the datapack is old and not work in 1.20.4 so gameplay is just creative mode . Use the book to warp around . none of the other commands work .

Now you can begin to work on the resourcepack . A quick conversion of the pack to Format 22 will show in game what was missed

[lowercasebtw]

alright

[Tsoccerguy3]

Here is a video of gameplay
https://www.youtube.com/channel/UCAKkSOHnlw945H9ETR0o1Cw

[Tsoccerguy3]

I did a initial port from 1.16.x to 1.20.4 , with the new 2.2.3 RC , It did most of the conversion .
missed a few blocks , Black_concrete ,iron door etc . Sometimes * .json files are left out if they are default and would be inherited from default .
I will need someway to update the data pack and command blocks . Any help much appreciated .

[lowercasebtw]

Did you get the latest jar from Jenkins or the Releases tab on GitHub? The releases tab has a outdated version, you can get the latest built jar on Jenkins.

…

On Wed, Mar 6, 2024 at 14:03 Tsoccerguy3 ***@***.***> wrote: I did a initial port from 1.16.x to 1.20.4 , with the new 2.2.3 RC , It did most of the conversion . missed a few blocks , Black_concrete ,iron door etc . Sometimes * .json files are left out if they are default and would be inherited from default . I will need someway to update the data pack and command blocks . Any help much appreciated . — Reply to this email directly, view it on GitHub <#100 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6E2U4VWGIJ75XMSGBTPF53YW5SB5AVCNFSM52DBTVG2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJYGE2TQNJQGQZA> . You are receiving this because you commented.Message ID: ***@***.***>

[Tsoccerguy3]

I did notice a ready made book had a text issue and did not work in 1.20.4 .It last worked in 1.20.1 . I'll need to read unto what has changed

[Tsoccerguy3]

Did you get the latest jar from Jenkins or the Releases tab on GitHub? The releases tab has a outdated version, you can get the latest built jar on Jenkins.

got the latest from realeases on this git compiled last week . did not see a Jenkins link

[lowercasebtw]

https://jenkins.dc1.agentdid127.com/job/resourcepackconverter/

There’s been some changes since last week, get the latest jar here ^

[Tsoccerguy3]

Tried 1.16.3 to 1.19.2 test with RC from Jenkens
found it missed grass , cyan_concrete , black_concreate and iron_door

The iron door is made up of 2 blocks top and bottom , each with 5 states . N S E W and water logged . A pack maker theorectically add a different texture to each of those ID's and states .

[Tsoccerguy3]

latest.txt

here is Minecrafts log . The parsing errors show what RC missed

[Tsoccerguy3]

Easy enough to manually fix . Generally caused by name changes in versions and in the case of doors check for states

[Tsoccerguy3]

In the case of concrete , there are 4 Alt models and a name change in newer versions

[Tsoccerguy3]

in the case of the iron door , the author of the pack left out the 4 iron_door model JSON files in 1.16.3 to use the games built in default . A game change in latter versions have different default model JSON files . This game change is why textures are not found.

I guess the logic should be looked into where the author has left out model JSON definitions in favor of using default and a game change in minecraft versions . The default 1.16.3 vs 1.19.2 JSON model definitions are very different and is why no texture is found and the error in the log.

This will be the case on other blocks and items as well

[CoryBorek]

Maybe if the other models for iron door are not found, just delete the file and assume default?

[Tsoccerguy3]

I tried the latest converter on the posted pack above for 1.16.2. I converted to 1.21.1 with some errors .
It missed custom names for models in cyan_concrete.json . black_concrete.json and some others in blockstates. The situation is that you must use default names in blockstate directory . From blockstates *.json files the models and textures can have custom names and properties. If a name is wrong or missing in blockstates , the default gets used . If there is a mistake is models , then missing texture issues . In the case of the few blocks in models they got missed because assumed to be default named. Still a issue with iron_door model causing missing texture . The custom models above verson 1.21.1 get all messed up. Can I suggest using the full 1.16.2 pack from the link above to test conversion on. It has examples of many features a pack can do.

If the converter can successfully convert that pack to each main minecraft version , then it could do anything

[Tsoccerguy3]

Maybe if the other models for iron door are not found, just delete the file and assume default?

deleting the blockstate name will grab the default minecraft texture from the version jar. The guy who did the map and pack needed more blocks that 1.16.x had in vanilla. They mapped textures to different states of the door. in this case the bottom hinged model of the iron door had a texture of a staircase railing mapped to some states.