allow erased module arguments #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flupe
commented
Nov 14, 2023
|
Known bug: opening such a module in another file will generate a qualified import statement, even though the definitions are not actually qualified in the generated Haskell code. |
|
I fixed the bug with module application. The output Haskell overly qualifies module applications, but Agda's prettyprinter does the same, so let's worry about it later. |
|
forgot to stage my new test file, hence the build failure... |
|
@flupe could you please resolve the conflicts in this PR so it can be included in 1.2? |
jespercockx
approved these changes
Nov 27, 2023
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #222.
Also fixes #223 by throwing a hard error when a function gets no compiled clauses.
We now only add scoped type variables for definitions in modules that are not top-level, but they still get quantified over the parameters of the top-level module. Could be convenient, could be annoying, remains to be seen which behavior is the one we want.
This PR only officially supports erased parameters, or explicit sort parameters. Some other may be allowed but we don't have special checks I think (yet).