Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serde save system #877

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

corwinkuiper
Copy link
Member

  • Changelog updated / no changelog update needed

@gwilymk
Copy link
Member

gwilymk commented Mar 21, 2025

I wonder if this should include corruption prevention by default?

@corwinkuiper
Copy link
Member Author

corwinkuiper commented Mar 22, 2025

I wonder if this should include corruption prevention by default?

What do you mean? crc of the data? Or do you mean we shouldn't have the id stuff?

@gwilymk
Copy link
Member

gwilymk commented Mar 22, 2025

No, the old trick of store it twice and overwrite the previous version. And if you shut down half way through, load the previous version and detect that happened some way. So if you turn off the console while saving is in progress, you at least have your old save. Bonus points if we can detect that it happened somehow and warn the player about it.

@corwinkuiper
Copy link
Member Author

Yep, would be cool to support that. I doubt storing the save twice will be too bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants