-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The background refactor (completely rethink backgrounds) #827
Open
gwilymk
wants to merge
51
commits into
agbrs:master
Choose a base branch
from
gwilymk:background-iter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massive change to how backgrounds work and a fundamental shift to how
agb
works in general. The main thing this is trying to achieve is to make it easier to manage multiple backgrounds or backgrounds where you only need to do something briefly.See the code in the dungeon puzzler example for how hard it was previously to do backgrounds easily.
This makes as much of a difference as switching from the 'unmanaged' sprites to the 'managed' sprites. You can suddenly have dynamically allocated backgrounds, and don't have to set them all up at the beginning. You can switch background tile modes as needed with affine (although affine support is still lacking a little due to some changes needed in the tile allocation).
Main changes:
set_pos
call which allows for easier dynamically generated items..clear
on backgrounds any more.Removals:
Still TODO:
.tileset
return is incorrect. Ideally we want to be able to use it with InfiniteScrolledMap