Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attributes support #16

Merged
merged 5 commits into from
Jun 1, 2023
Merged

add attributes support #16

merged 5 commits into from
Jun 1, 2023

Conversation

agardnerIT
Copy link
Owner

@agardnerIT agardnerIT commented May 27, 2023

This PR:

  • Adds tracepusher support for sending span attributes

TODO (seperate PR)

The OpenTelemetry docs only show stringValue as a possible type, but hint at floats, ints and arrays being allowed too.

  • Asked in Slack. Wait for a resolution to this thread
  • Update code + readme

Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
@agardnerIT
Copy link
Owner Author

From Georg Pirklbauer on Slack:

TL;DR: stringValue, boolValue, intValue, doubleValue, arrayValue, kvlistValue, bytesValue, with arrayValue and kvlistValue again being able to contain all of the aforementioned types.

@agardnerIT agardnerIT self-assigned this Jun 1, 2023
@agardnerIT agardnerIT merged commit 290c189 into main Jun 1, 2023
@agardnerIT agardnerIT deleted the feat/span-attributes branch June 1, 2023 02:30
@agardnerIT agardnerIT mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant