Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Gemini Client fixes #264

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Google Gemini Client fixes #264

merged 1 commit into from
Dec 21, 2024

Conversation

marklysze
Copy link
Collaborator

Why are these changes needed?

This PR will be used to fix Google Gemini client class bugs. If anyone has any, let's work on them here.

Related issue number

N/A

Checks

@marklysze marklysze added bug Something isn't working alt-models labels Dec 20, 2024
qingyun-wu
qingyun-wu approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingyun-wu qingyun-wu added this pull request to the merge queue Dec 21, 2024
Merged via the queue into main with commit 35de7f8 Dec 21, 2024
203 of 211 checks passed
@sonichi sonichi deleted the gemini-fixes-202412 branch December 21, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingyun-wu qingyun-wu qingyun-wu approved these changes

Assignees
No one assigned
Labels
alt-models bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marklysze @qingyun-wu