Skip to content

Allow lists to be a parameter in a function for a tool #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

marklysze
Copy link
Collaborator

@marklysze marklysze commented Apr 17, 2025

Why are these changes needed?

When a function is converted to a tool it can cause a crash if it has a parameter that is a list.

This PR is to fix this issue.

Raised as an issue on Discord, message link.

Note: I've tested if this was an issue for response formats that had a parameter as a list and it isn't.

Related issue number

N/A

Checks

@marklysze marklysze added the bug Something isn't working label Apr 17, 2025
@marklysze marklysze self-assigned this Apr 17, 2025
@marklysze marklysze requested a review from davorrunje April 17, 2025 19:18
@davorrunje davorrunje added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 875145d Apr 17, 2025
17 checks passed
@davorrunje davorrunje deleted the listsupportfortoolsignature branch April 17, 2025 20:23
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
autogen/tools/function_utils.py 84.61% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (ad68099) and HEAD (ddd103c). Click for more details.

HEAD has 1449 uploads less than BASE
Flag BASE (ad68099) HEAD (ddd103c)
core-without-llm 14 1
3.9 94 0
ubuntu-latest 169 1
optional-deps 175 0
commsagent-telegram 9 0
3.13 95 0
macos-latest 115 0
commsagent-discord 9 0
3.11 76 1
browser-use 7 0
3.10 108 0
3.12 36 0
commsagent-slack 9 0
windows-latest 125 0
jupyter-executor 9 0
interop-pydantic-ai 9 0
mcp 13 0
rag 7 0
retrievechat-qdrant 14 0
websockets 9 0
interop-langchain 9 0
wikipedia-api 13 0
retrievechat 15 0
twilio 9 0
interop 13 0
docs 6 0
interop-crewai 9 0
retrievechat-mongodb 10 0
graph-rag-falkor-db 6 0
crawl4ai 13 0
google-api 13 0
retrievechat-pgvector 10 0
agent-eval 1 0
anthropic 16 0
gemini 15 0
cerebras 15 0
gpt-assistant-agent 3 0
lmm 4 0
retrievechat-couchbase 3 0
teachable 4 0
long-context 3 0
llama-index-agent 3 0
websurfer 15 0
mistral 14 0
together 14 0
groq 14 0
ollama 15 0
bedrock 15 0
cohere 15 0
swarm 14 0
integration 24 0
falkordb 2 0
core-llm 8 0
gemini-realtime 1 0
neo4j 2 0
captainagent 1 0
autobuild 1 0
openai-realtime 1 0
deepseek 1 0
Files with missing lines Coverage Δ
autogen/tools/function_utils.py 90.41% <84.61%> (-0.90%) ⬇️

... and 75 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants