-
Notifications
You must be signed in to change notification settings - Fork 304
Disable default cache when both cache and cache_seed are not set #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Hey @kumaranvpl, thanks for putting this together. This is working for me now:
When using the Cache context manager, I tried the below and it didn't work...
Second run output:
... then I realised I needed to pass that cache into the
|
It's working as planned now, thank you! I'll approve the changes. I think we need some specific documentation on caching, I'll add an Issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 79 files with indirect coverage changes 🚀 New features to boost your workflow:
|
@marklysze I agree with you regarding context manager. If we are using context manager, then |
Why are these changes needed?
Related issue number
Closes #1640
Checks