Skip to content

fix: register_handoff is not working as expected in a_run_swarm #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2025

Conversation

karikalanarun
Copy link
Contributor

@karikalanarun karikalanarun commented Apr 10, 2025

Why are these changes needed?

I am doing one poc with a_run_swarm. I am just replicating the context router example using a_run_swarm. it didn't get transitioned properly. I got an error saying,

AttributeError: 'ConversableAgent' object has no attribute '_swarm_manager'

Closes #1603

Checks

I haven't done anything in checks. But, I am thinking it's a minor fix, so.

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2025

CLA assistant check
All committers have signed the CLA.

@karikalanarun karikalanarun marked this pull request as draft April 10, 2025 14:28
@karikalanarun karikalanarun marked this pull request as ready for review April 10, 2025 14:30
@sternakt sternakt self-requested a review April 10, 2025 14:32
@kumaranvpl
Copy link
Collaborator

@sternakt sternakt added this pull request to the merge queue Apr 11, 2025
Merged via the queue into ag2ai:main with commit 6d0ee2a Apr 11, 2025
12 checks passed
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ There is a different number of reports uploaded between BASE (d881aaa) and HEAD (81cbc55). Click for more details.

HEAD has 1413 uploads less than BASE
Flag BASE (d881aaa) HEAD (81cbc55)
core-without-llm 14 1
3.9 91 0
ubuntu-latest 166 1
3.11 76 1
commsagent-discord 9 0
optional-deps 165 0
3.10 105 0
macos-latest 112 0
3.13 92 0
3.12 36 0
windows-latest 122 0
jupyter-executor 9 0
commsagent-telegram 9 0
rag 7 0
browser-use 7 0
retrievechat 15 0
retrievechat-pgvector 10 0
interop-crewai 9 0
retrievechat-mongodb 10 0
mcp 13 0
retrievechat-qdrant 13 0
google-api 13 0
twilio 9 0
websockets 9 0
interop-langchain 9 0
wikipedia-api 13 0
graph-rag-falkor-db 6 0
interop 13 0
crawl4ai 13 0
interop-pydantic-ai 9 0
docs 6 0
agent-eval 1 0
llama-index-agent 3 0
gpt-assistant-agent 3 0
websurfer 15 0
gemini 15 0
lmm 4 0
retrievechat-couchbase 3 0
long-context 3 0
cohere 15 0
groq 14 0
teachable 4 0
anthropic 16 0
cerebras 15 0
together 14 0
mistral 14 0
ollama 15 0
bedrock 15 0
swarm 14 0
integration 24 0
falkordb 2 0
core-llm 9 0
openai-realtime 1 0
gemini-realtime 1 0
neo4j 2 0
deepseek 1 0
captainagent 1 0
autobuild 1 0
openai 1 0

see 80 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix a_run_swarm missing _link_agents_to_swarm_manager
4 participants