Skip to content

Use sender, recipient instead of sender_name and recipient_name #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 10, 2025

Conversation

kumaranvpl
Copy link
Collaborator

Why are these changes needed?

Related issue number

Closes #1585

Checks

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2025

CLA assistant check
All committers have signed the CLA.

@kumaranvpl kumaranvpl requested a review from Copilot April 9, 2025 14:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

autogen/messages/agent_messages.py:95

  • [nitpick] The updated decorator mapping is clear; please verify that similar mappings throughout this module follow the same pattern for consistency.
@deprecated_by(FunctionResponseEvent, param_mapping={"sender_name": "sender", "recipient_name": "recipient"})

autogen/events/agent_events.py:299

  • [nitpick] Using inline hasattr() checks works but consider abstracting this conversion into a helper to promote consistency across event initializers.
sender = chat_info["sender"].name if hasattr(chat_info["sender"], "name") else chat_info["sender"]

autogen/events/agent_events.py:911

  • [nitpick] The repeated conversion logic for code_blocks could be refactored into a helper function to improve readability and maintainability.
code_blocks = [code_block.language if hasattr(code_block, "language") else code_block for code_block in code_blocks]

@davorrunje davorrunje added this pull request to the merge queue Apr 9, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 9, 2025
* Rename sender_name, recipient_name to sender and recipient

* Add deserialization test cases

* Move serialization tests to separate method

* Update version to 0.8.6rc0
@kumaranvpl kumaranvpl removed this pull request from the merge queue due to a manual request Apr 10, 2025
@kumaranvpl kumaranvpl added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit d3485aa Apr 10, 2025
17 checks passed
@kumaranvpl kumaranvpl deleted the rename-sender-name branch April 10, 2025 05:09
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ There is a different number of reports uploaded between BASE (bc81462) and HEAD (99e71d8). Click for more details.

HEAD has 1339 uploads less than BASE
Flag BASE (bc81462) HEAD (99e71d8)
3.9 89 0
ubuntu-latest 160 1
commsagent-discord 9 0
optional-deps 157 0
core-without-llm 14 1
macos-latest 103 0
3.11 71 1
3.10 98 0
3.13 88 0
browser-use 6 0
3.12 32 0
graph-rag-falkor-db 6 0
commsagent-telegram 9 0
windows-latest 115 0
rag 7 0
retrievechat-mongodb 9 0
jupyter-executor 9 0
interop-pydantic-ai 9 0
interop-crewai 9 0
retrievechat-pgvector 10 0
docs 6 0
mcp 12 0
twilio 9 0
wikipedia-api 13 0
websockets 9 0
crawl4ai 13 0
interop 13 0
retrievechat-qdrant 13 0
google-api 13 0
interop-langchain 9 0
cerebras 16 0
teachable 4 0
agent-eval 1 0
long-context 3 0
llama-index-agent 3 0
lmm 4 0
gpt-assistant-agent 3 0
gemini 12 0
retrievechat 7 0
websurfer 15 0
retrievechat-couchbase 3 0
anthropic 14 0
mistral 13 0
bedrock 15 0
together 12 0
groq 12 0
cohere 13 0
ollama 13 0
swarm 14 0
integration 23 0
falkordb 2 0
core-llm 11 0
neo4j 2 0
captainagent 1 0
autobuild 1 0
openai-realtime 2 0
deepseek 2 0
openai 1 0
Files with missing lines Coverage Δ
autogen/events/agent_events.py 96.49% <100.00%> (-1.66%) ⬇️
autogen/events/base_event.py 87.50% <100.00%> (+2.08%) ⬆️
autogen/messages/agent_messages.py 58.37% <100.00%> (ø)
autogen/version.py 100.00% <100.00%> (ø)

... and 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use sender, recipient instead of sender_name and recipient_name
4 participants