-
Notifications
You must be signed in to change notification settings - Fork 305
Use sender, recipient instead of sender_name and recipient_name #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
autogen/messages/agent_messages.py:95
- [nitpick] The updated decorator mapping is clear; please verify that similar mappings throughout this module follow the same pattern for consistency.
@deprecated_by(FunctionResponseEvent, param_mapping={"sender_name": "sender", "recipient_name": "recipient"})
autogen/events/agent_events.py:299
- [nitpick] Using inline hasattr() checks works but consider abstracting this conversion into a helper to promote consistency across event initializers.
sender = chat_info["sender"].name if hasattr(chat_info["sender"], "name") else chat_info["sender"]
autogen/events/agent_events.py:911
- [nitpick] The repeated conversion logic for code_blocks could be refactored into a helper function to improve readability and maintainability.
code_blocks = [code_block.language if hasattr(code_block, "language") else code_block for code_block in code_blocks]
* Rename sender_name, recipient_name to sender and recipient * Add deserialization test cases * Move serialization tests to separate method * Update version to 0.8.6rc0
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 74 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Why are these changes needed?
Related issue number
Closes #1585
Checks