Skip to content

Fix: AttributeError: 'HttpUrl' object has no attribute 'partition' in Ollama Client #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

marufaytekin
Copy link
Collaborator

@marufaytekin marufaytekin commented Mar 20, 2025

Why are these changes needed?

Related issue number

Closes #1405

Checks

@marufaytekin marufaytekin changed the title adding a work around for ollama client bug with pydantic 2 Fix: AttributeError: 'HttpUrl' object has no attribute 'partition' in Ollama Client Mar 20, 2025
Copy link
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing @marufaytekin!

@marufaytekin marufaytekin added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 3975139 Mar 20, 2025
17 checks passed
@marufaytekin marufaytekin deleted the bug_fix_1405 branch March 20, 2025 03:13
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
autogen/oai/ollama.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2e211d1) and HEAD (9a1a513). Click for more details.

HEAD has 1163 uploads less than BASE
Flag BASE (2e211d1) HEAD (9a1a513)
core-without-llm 14 1
3.9 74 0
ubuntu-latest 118 1
macos-latest 104 0
commsagent-discord 9 0
optional-deps 141 0
3.11 48 1
3.13 84 0
browser-use 3 0
3.10 94 0
windows-latest 114 0
commsagent-telegram 9 0
jupyter-executor 9 0
3.12 36 0
commsagent-slack 9 0
retrievechat-mongodb 10 0
interop-crewai 9 0
retrievechat-pgvector 10 0
interop-pydantic-ai 9 0
interop 9 0
crawl4ai 9 0
websockets 9 0
twilio 9 0
graph-rag-falkor-db 6 0
retrievechat 15 0
docs 6 0
interop-langchain 9 0
retrievechat-qdrant 14 0
gpt-assistant-agent 3 0
agent-eval 1 0
teachable 3 0
gemini 14 0
llama-index-agent 3 0
websurfer 15 0
lmm 3 0
long-context 3 0
retrievechat-couchbase 3 0
anthropic 15 0
cerebras 14 0
mistral 14 0
swarm 14 0
together 14 0
groq 14 0
cohere 15 0
ollama 14 0
bedrock 14 0
Files with missing lines Coverage Δ
autogen/oai/ollama.py 16.15% <0.00%> (-0.69%) ⬇️

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marufaytekin marufaytekin self-assigned this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AttributeError: 'HttpUrl' object has no attribute 'partition'
2 participants