Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for max_consecutive_auto_reply #1374

Merged
merged 5 commits into from
Mar 18, 2025
Merged

bug fix for max_consecutive_auto_reply #1374

merged 5 commits into from
Mar 18, 2025

Conversation

marufaytekin
Copy link
Collaborator

@marufaytekin marufaytekin commented Mar 17, 2025

Why are these changes needed?

Related issue number

Closes #600

Checks

@marufaytekin marufaytekin requested a review from marklysze March 17, 2025 09:11
@davorrunje
Copy link
Collaborator

@marufaytekin can you please add a test for this?

@marufaytekin marufaytekin marked this pull request as ready for review March 18, 2025 01:23
Copy link
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marufaytekin!

@marklysze marklysze self-requested a review March 18, 2025 03:22
@marklysze marklysze added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit b0d64cc Mar 18, 2025
17 checks passed
@marklysze marklysze deleted the bug_fix_600_2 branch March 18, 2025 03:29
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ There is a different number of reports uploaded between BASE (e627c1c) and HEAD (cef9b5a). Click for more details.

HEAD has 1126 uploads less than BASE
Flag BASE (e627c1c) HEAD (cef9b5a)
3.9 73 0
ubuntu-latest 113 1
optional-deps 141 0
commsagent-telegram 9 0
3.10 92 0
commsagent-discord 9 0
3.13 83 0
core-without-llm 14 1
browser-use 3 0
3.11 44 1
macos-latest 102 0
3.12 33 0
commsagent-slack 9 0
windows-latest 110 0
retrievechat-pgvector 9 0
jupyter-executor 9 0
twilio 9 0
retrievechat-mongodb 9 0
interop 9 0
retrievechat-qdrant 13 0
retrievechat 14 0
graph-rag-falkor-db 6 0
crawl4ai 9 0
websockets 9 0
docs 6 0
interop-langchain 9 0
interop-crewai 9 0
interop-pydantic-ai 9 0
gpt-assistant-agent 3 0
cohere 11 0
agent-eval 1 0
lmm 3 0
websurfer 14 0
gemini 14 0
long-context 3 0
swarm 12 0
teachable 3 0
retrievechat-couchbase 2 0
llama-index-agent 3 0
together 14 0
groq 14 0
ollama 14 0
bedrock 12 0
anthropic 14 0
cerebras 14 0
mistral 14 0
Files with missing lines Coverage Δ
autogen/agentchat/conversable_agent.py 66.44% <100.00%> (-1.79%) ⬇️

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: max_consecutive_auto_reply not working on recipient agent
3 participants