Skip to content

Remove pysqlite3-binary dependency #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2025

Conversation

rjambrecic
Copy link
Collaborator

@rjambrecic rjambrecic commented Mar 10, 2025

Why are these changes needed?

Remove pysqlite3 from dependencies.

  • pysqlite3 installation is problematic (at least) on Mac
  • pysqlite3 is needed only if sqlite3 < 3.35.0 which was released on 2021-03-12

Related issue number

Closes #1285

Checks

@rjambrecic rjambrecic marked this pull request as draft March 10, 2025 14:58
@davorrunje davorrunje added this pull request to the merge queue Mar 10, 2025
@davorrunje davorrunje removed this pull request from the merge queue due to a manual request Mar 10, 2025
@davorrunje davorrunje self-requested a review March 10, 2025 21:16
@davorrunje davorrunje added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@sonichi sonichi requested review from kumaranvpl and LeoLjl March 11, 2025 16:45
@sonichi sonichi added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@rjambrecic rjambrecic added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit f667407 Mar 12, 2025
16 checks passed
@rjambrecic rjambrecic deleted the fix-agent-builder-optinal-dependency branch March 12, 2025 08:17
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 95 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Optional dependency captainagent installs old ag2 version
2 participants