Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Refresh Token Process #39

Merged
merged 15 commits into from
Apr 7, 2023
Merged

Conversation

Rapter1990
Copy link
Contributor

What I've done so far is based on the implementation of refresh token process

Here is the step which I've done until now.

  1. Implementation of Refresh Token process in AuthController and its service with their test class covering service test as unit test and integration test as controller test

@Rapter1990 Rapter1990 self-assigned this Mar 31, 2023
@Rapter1990 Rapter1990 added the feature New feature or request label Mar 31, 2023
# Conflicts:
#	src/main/java/com/ays/backend/user/controller/AuthController.java
#	src/main/java/com/ays/backend/user/model/Token.java
#	src/main/java/com/ays/backend/user/model/entities/RefreshToken.java
#	src/main/java/com/ays/backend/user/model/entities/UserEntity.java
#	src/main/java/com/ays/backend/user/repository/RefreshTokenRepository.java
#	src/main/java/com/ays/backend/user/security/JwtTokenProvider.java
#	src/main/java/com/ays/backend/user/service/AuthService.java
#	src/main/java/com/ays/backend/user/service/RefreshTokenService.java
#	src/main/java/com/ays/backend/user/service/impl/AuthServiceImpl.java
#	src/main/java/com/ays/backend/user/service/impl/RefreshTokenServiceImpl.java
#	src/main/java/com/ays/backend/user/service/impl/UserServiceImpl.java
#	src/test/java/com/ays/backend/user/controller/AuthControllerTest.java
#	src/test/java/com/ays/backend/user/service/AuthServiceTest.java
#	src/test/java/com/ays/backend/user/service/RefreshTokenServiceTest.java
@Rapter1990
Copy link
Contributor Author

@skayikci Can you check and review the code?

Copy link
Collaborator

@skayikci skayikci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While doing the tests, none of the endpoints are working, either returning 200 or returning an empty response. please fix them.

@Rapter1990 Rapter1990 dismissed skayikci’s stale review April 6, 2023 23:27

We'll handle with it after this pull request is over.

@Rapter1990 Rapter1990 merged commit 55cc08c into main Apr 7, 2023
@Rapter1990 Rapter1990 deleted the features/refreshtoken branch April 7, 2023 20:59
@agitrubard agitrubard added this to the v1.0.0 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants