Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-142 | Forbid FirstName & LastName To Start With Special Characters #288

Merged

Conversation

MenekseYuncu
Copy link
Contributor

We have revised Regex so that the firstname and the lastname cannot start with special characters.

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes
      made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.
  • Jira Issue Transition:

    • If this pull request is related to a Jira issue, ensure that the issue is moved to the "In Review" status on the
      Jira board.

Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buradaki validasyonu sağlayan testler ekleyebilir miyiz?

@AhmetAksunger
Copy link
Contributor

Buradaki validasyonu sağlayan testler ekleyebilir miyiz?

Ekledik, inceler misin?

agitrubard
agitrubard previously approved these changes Feb 16, 2024
Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MenekseYuncu @AhmetAksunger Elinize sağlık, parameterized testler bayağı iyi olmuş 🚀
Bir ufak düzenleme var onu yaptıktan sonra mergeleyebiliriz ✅

anilhazar
anilhazar previously approved these changes Feb 16, 2024
@agitrubard agitrubard dismissed stale reviews from anilhazar and themself via 6e8f28b February 17, 2024 07:28
@agitrubard agitrubard self-assigned this Feb 17, 2024
@agitrubard agitrubard merged commit ad9b0aa into main Feb 17, 2024
1 check passed
@agitrubard agitrubard deleted the bug/AYS-142/resolve-name-starting-with-special-character branch February 17, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants