Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-2 | Fix the issue not showing phone number info in AdminUserRegisterApplicationResponse and Add Some Java Docs in Some Mapper Classes #279

Conversation

Rapter1990
Copy link
Contributor

@Rapter1990 Rapter1990 commented Jan 6, 2024

Please provide a brief description of the changes made in this pull request.

  • Fix the issue not showing phone number info in AdminUserRegisterApplicationResponse by defining map method in AdminUserRegisterApplicationToAdminUserRegisterApplicationResponseMapper
  • Add some Java Docs in some mapper classes as they cannot be defined.

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes
      made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.
  • Jira Issue Transition:

    • If this pull request is related to a Jira issue, ensure that the issue is moved to the "In Review" status on the
      Jira board.

…EntityToAdminUserMapper, AdminUserRegisterApplicationEntityToAdminUserRegisterApplicationMapper, AdminUserRegisterApplicationToAdminUserRegisterApplicationCreateResponseMapper, AdminUserRegisterApplicationToAdminUserRegisterApplicationsResponseMapper
@Rapter1990 Rapter1990 changed the title AYS-2 | Fix the issue not showing phone number info in AdminUserRegisterApplicationResponse AYS-2 | Fix the issue not showing phone number info in AdminUserRegisterApplicationResponse and Add Some Java Docs in Some Mapper Classes Jan 6, 2024
Copy link
Contributor

@AhmetAksunger AhmetAksunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eline sağlık.

@agitrubard agitrubard merged commit 2d4d2b4 into main Jan 7, 2024
4 checks passed
@agitrubard agitrubard deleted the bugfix/ays-2/show-phone-number--of-admin-user-register-application-response branch January 7, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants