Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#105 | Create Assignment And Location Domain #112

Merged
merged 38 commits into from
Jul 27, 2023

Conversation

Rapter1990
Copy link
Contributor

What I have done so far is shown step by step

  • Define Assignment and Location domain
    • Entity for Assignment and Location entity
    • Enum for status of assignment
    • Dto for request and response in both Assignment and Location,
    • Mapper process for Assignment and Location
    • Repository for Assignment and Location
    • Exception Handling for Assignment and Location
    • Java Doc to understand each class with its methods for Assignment and Location

@Rapter1990 Rapter1990 self-assigned this Jul 3, 2023
@Rapter1990 Rapter1990 added the in review This issue in review label Jul 3, 2023
@agitrubard agitrubard removed the in review This issue in review label Jul 4, 2023
@Rapter1990 Rapter1990 added the in review This issue in review label Jul 4, 2023
@ilkerCelimli
Copy link
Contributor

Ellerine sağlık ben bi sıkıntı göremedim.

ilkerCelimli
ilkerCelimli previously approved these changes Jul 9, 2023
@Rapter1990 Rapter1990 added the feature New feature or request label Jul 9, 2023
emreylmaz
emreylmaz previously approved these changes Jul 10, 2023
Copy link
Contributor

@emreylmaz emreylmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gayet iyi gözüküyor eline sağlık!

@Rapter1990 Rapter1990 changed the title Create Assignment And Location Domain #105 | Create Assignment And Location Domain Jul 10, 2023
@agitrubard agitrubard removed the in review This issue in review label Jul 12, 2023
moaydogdu
moaydogdu previously approved these changes Jul 13, 2023
Copy link
Contributor

@moaydogdu moaydogdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…tyMapper, AssignmentToAssignmentResponseMapper
…ilableException, AysAssignmentAlreadyDoneException, AysAssignmentAlreadyInProgressException, AysAssignmentAlreadyReservedException and AysAssignmentNotExistByIdException
@Rapter1990 Rapter1990 dismissed stale reviews from emreylmaz, moaydogdu, and ilkerCelimli via 2aefc95 July 23, 2023 12:53
agitrubard
agitrubard previously approved these changes Jul 23, 2023
Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eline sağlık 🙌🏼 Approved ✅

@Rapter1990 Veri modeli ile ilgili değişiklikleri mergelendikten sonra bu branch'i mergeleyelim 👍🏼

moaydogdu
moaydogdu previously approved these changes Jul 24, 2023
@Rapter1990 Rapter1990 dismissed stale reviews from moaydogdu and agitrubard via b1ba1da July 26, 2023 17:43
@agitrubard agitrubard merged commit 90d28c6 into main Jul 27, 2023
@agitrubard agitrubard deleted the feature/105/create-domain-for-location-and-assignment branch July 27, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atama ve Lokasyon Geliştirmeleri İçin Alt Yapının Oluşturulması
6 participants