Add sign and verify for personal messages #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outergod
suggested changes
May 17, 2018
src/utils/crypto.js
Outdated
| @@ -87,6 +87,19 @@ function verify (str, signature, publicKey) { | |||
| return nacl.sign.detached.verify(new Uint8Array(str), signature, publicKey) | |||
| } | |||
|
|
|||
| const personalMessageToBinary = (message) => { | |||
There was a problem hiding this comment.
Please use function instead of assigning anonymous functions to consts unless you have a strong reason not to, e.g. because you're assigning a function returned by another function of higher order.
test/crypto.js
Outdated
|
|
||
| describe('sign', () => { | ||
| it('should produce correct signature', () => { | ||
| let s = Crypto.sign(txBinary, privateKey) |
There was a problem hiding this comment.
Use const instead of let wherever possible (please disregard that old code does it wrong)
test/crypto.js
Outdated
|
|
||
| it('should verify message with non-ASCII chars', () => { | ||
| const result = Crypto.verifyPersonalMessage( | ||
| messageNonASCII, messageNonASCIISignature, publicKey) |
There was a problem hiding this comment.
Don't you have any limits on line length? Usually, I'm trying not to make lines longer than 100 chars.
davidyuk
force-pushed
the
feature/personal-messages
branch
from
65fb0f5 to
293bba1
Compare
outergod
force-pushed
the
feature/personal-messages
branch
from
293bba1 to
816ceb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Voting app, it is necessary to implement methods for signing and verifying of personal messages. But I can't find anything that describes how this messages should be signed on Aeternity. I propose to use the approach similar to Bitcoin and Ethereum approaches.
In ethereum/go-ethereum#14794 proposed to use
varintfrom Bitcoin to store message length, I suppose to implement it later in case if this whole approach is acceptable.Depends on #32