Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValueVariable checks #242

Merged
merged 18 commits into from
Mar 11, 2023

Conversation

brandonwillard
Copy link
Member

This PR fixes a number of incorrect checks for ValueVariables. It also closes #240, makes updates according to recent Aesara deprecations, and adjusts the tests to use RandomStream (e.g. so that we don't miss out on the updates that would normally appear in such graphs).

@brandonwillard brandonwillard added bug Something isn't working important This label is used to indicate priority over things not given this label labels Mar 11, 2023
@brandonwillard brandonwillard self-assigned this Mar 11, 2023
@brandonwillard brandonwillard requested review from rlouf and zoj613 March 11, 2023 02:31
@brandonwillard
Copy link
Member Author

After these fixes/updates, test_transforms.test_transform_reused_measurable needed to be marked as xfail. Since that test is for a non-standard situation, we should merge this first and address that later.

@brandonwillard brandonwillard enabled auto-merge (rebase) March 11, 2023 02:35
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 70.00% and project coverage change: -0.43 ⚠️

Comparison is base (5f5aaa4) 96.19% compared to head (f8f3afd) 95.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   96.19%   95.76%   -0.43%     
==========================================
  Files          12       12              
  Lines        1996     2006      +10     
  Branches      239      243       +4     
==========================================
+ Hits         1920     1921       +1     
- Misses         39       46       +7     
- Partials       37       39       +2     
Impacted Files Coverage Δ
aeppl/censoring.py 96.15% <ø> (ø)
aeppl/cumsum.py 100.00% <ø> (ø)
aeppl/logprob.py 97.54% <ø> (-0.55%) ⬇️
aeppl/rewriting.py 95.91% <ø> (ø)
aeppl/scan.py 96.90% <ø> (ø)
aeppl/tensor.py 100.00% <ø> (ø)
aeppl/printing.py 90.23% <62.50%> (-1.54%) ⬇️
aeppl/dists.py 94.50% <100.00%> (ø)
aeppl/mixture.py 96.49% <100.00%> (ø)
aeppl/transforms.py 96.68% <100.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brandonwillard brandonwillard disabled auto-merge March 11, 2023 04:11
@brandonwillard brandonwillard merged commit 906c10d into aesara-devs:main Mar 11, 2023
@brandonwillard brandonwillard deleted the fix-sub-transform branch March 11, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important This label is used to indicate priority over things not given this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The PERT example in the documentation does not work
1 participant