-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ValueVariable
checks
#242
Fix ValueVariable
checks
#242
Conversation
111d968
to
63c3c42
Compare
After these fixes/updates, |
63c3c42
to
f8f3afd
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
- Coverage 96.19% 95.76% -0.43%
==========================================
Files 12 12
Lines 1996 2006 +10
Branches 239 243 +4
==========================================
+ Hits 1920 1921 +1
- Misses 39 46 +7
- Partials 37 39 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This PR fixes a number of incorrect checks for
ValueVariable
s. It also closes #240, makes updates according to recent Aesara deprecations, and adjusts the tests to useRandomStream
(e.g. so that we don't miss out on the updates that would normally appear in such graphs).