Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v0.25.2 #634

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Prepare release v0.25.2 #634

merged 3 commits into from
Feb 18, 2025

Conversation

lllamnyp
Copy link
Member

@lllamnyp lllamnyp commented Feb 18, 2025

Summary by CodeRabbit

  • Chores
    • Updated the dashboard container build process to use an updated source reference, ensuring that the latest version is built.
  • New Features
    • Added deployment configuration for the kamaji provider, including resource limits for CPU and memory.
    • Introduced resource management configurations for the keycloak-operator, specifying limits and requests for memory and CPU.
    • Updated various components to version v0.25.2, including the dashboard, kubeappsapis, and cozystack images, ensuring users benefit from the latest features and improvements.

@lllamnyp lllamnyp requested a review from kvaps as a code owner February 18, 2025 14:23
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 18, 2025
Copy link
Contributor

coderabbitai bot commented Feb 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This change updates the commit reference used in the dashboard application's Dockerfile. The ARG COMMIT_REF value has been modified from one commit hash to another. Consequently, the source code fetched during the Docker image build process now points to the new commit, affecting the version of the application being built. Additionally, new resource configurations have been added for the kamaji provider in the providers.yaml file and for the keycloak-operator in the values.yaml file, enhancing resource management for these components.

Changes

File(s) Change Summary
packages/system/dashboard/images/dashboard/Dockerfile Updated ARG COMMIT_REF from dd02680d796c962b8dcc4e5ea70960a846c1acdc to 190ea544aeb0be74bb6d1aa4bb474910559e7ecd, affecting the source code fetched during build.
packages/system/capi-providers/templates/providers.yaml Added new deployment configuration for kamaji under ControlPlaneProvider, specifying resource limits for the manager container.
packages/system/keycloak-operator/values.yaml Introduced new resource management configurations for keycloak-operator, defining limits and requests for memory and CPU.
packages/apps/ferretdb/images/postgres-backup.tag Updated Docker image reference SHA256 digest for postgres-backup from 6a8ec7e7052f2d02ec5457d7cbac6ee52b3ed93a883988a192d1394fc7c88117 to 71cdf8bdab3d6f27edeec0ab33ddd8c7b56675a4f2d7bbf4d3e09b70ecb43375.
packages/apps/kubernetes/images/kubevirt-cloud-provider.tag Updated image digest for kubevirt-cloud-provider from sha256:461aee26669a15aa8febee5de43e1e5ec72b924ab3fe3fde2a0725ceef08a09b to sha256:5f1ab06264c09f3dc7bfc43db0b6e68235ac44f83e8a5277dfb74fe6902d6dca.
packages/apps/kubernetes/images/ubuntu-container-disk.tag Updated SHA256 digest for ubuntu-container-disk from c2c26e7a61208415b044d32872c8692bb46e9b62746ce45166d6cb7bd15c597b to b882ff398d297824dbf73dee948cfa684cb18006b91bd152e1f03ed22d7190fa.
packages/apps/mysql/images/mariadb-backup.tag Updated image digest for mariadb-backup from sha256:4bbfbb397bd7ecea45507ca47989c51429c4a24f40853ac92583e5b5b352fbea to sha256:5994e3f7a57054e3cebc532fa29a90edc9a97befe8993cec011e3e726c83e9bd.
packages/apps/postgres/images/postgres-backup.tag Updated image digest for postgres-backup from sha256:6a8ec7e7052f2d02ec5457d7cbac6ee52b3ed93a883988a192d1394fc7c88117 to sha256:71cdf8bdab3d6f27edeec0ab33ddd8c7b56675a4f2d7bbf4d3e09b70ecb43375.
packages/core/installer/values.yaml Updated cozystack image version from v0.25.1 to v0.25.2 with a new SHA256 digest.
packages/core/testing/values.yaml Updated e2e service image version from v0.25.1 to v0.25.2 with a new SHA256 digest.
packages/extra/bootbox/images/matchbox.tag Updated matchbox image version from v0.25.1 to v0.25.2 with a new SHA256 digest.
packages/system/bucket/images/s3manager.tag Updated SHA256 digest for s3manager from b4ea039e7a04edb1afb3dda86b5caf0fda6dcf826886118058560bf876c7197b to e50aecd2158490cb383cef28b8b066aef847782cd826b161fccd91c928fcb500.
packages/system/cozystack-api/values.yaml Updated cozystackAPI image version from v0.25.1 to v0.25.2 with a new SHA256 digest.
packages/system/cozystack-controller/values.yaml Updated cozystack-controller image version from v0.25.1 to v0.25.2 with a new SHA256 digest; also updated cozystackVersion.
packages/system/dashboard/charts/kubeapps/templates/dashboard/configmap.yaml Updated appVersion in config.json from v0.25.1 to v0.25.2.
packages/system/dashboard/values.yaml Updated image tags and digests for dashboard and kubeappsapis from v0.25.1 to v0.25.2 with corresponding SHA256 digest updates.
packages/system/kamaji/values.yaml Updated kamaji image tag from v0.25.1 to v0.25.2 with a new SHA256 digest.
packages/system/kubeovn/values.yaml Updated kubeovn image tag from v1.13.2 with a new SHA256 digest.

Possibly related PRs

  • feature/update-dashboard-image #636: The changes in the main PR, which update the ARG COMMIT_REF in the Dockerfile for the dashboard application, are related to the changes in the retrieved PR that update the image tags and digests for the dashboard component in the values.yaml file, as both affect the versioning and build process of the dashboard application.
  • Prepare release v0.21.0 #546: The changes in the main PR, which update the ARG COMMIT_REF in the Dockerfile for the dashboard application, are related to the changes in the retrieved PR that also modify the Dockerfile for the Kubeapps project by updating the ARG COMMIT_REF, indicating a direct connection at the code level.
  • Update kubeapps v2.12.0 #533: The changes in the main PR, which update the commit reference in the Dockerfile for the dashboard application, are related to the retrieved PR that updates the version in the same Dockerfile for the Kubeapps application, as both involve modifications to the packages/system/dashboard/images/dashboard/Dockerfile.

Poem

Hopping through lines of Docker code so light,
I nibble on commits with all my might.
Old hashes left behind, new ones in view—
My whiskers twitch with joy for something fresh and new!
With each updated build, my rabbit heart sings too.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1844e22 and 0f68db6.

📒 Files selected for processing (17)
  • packages/apps/ferretdb/images/postgres-backup.tag (1 hunks)
  • packages/apps/kubernetes/images/kubevirt-cloud-provider.tag (1 hunks)
  • packages/apps/kubernetes/images/ubuntu-container-disk.tag (1 hunks)
  • packages/apps/mysql/images/mariadb-backup.tag (1 hunks)
  • packages/apps/postgres/images/postgres-backup.tag (1 hunks)
  • packages/core/installer/values.yaml (1 hunks)
  • packages/core/testing/values.yaml (1 hunks)
  • packages/extra/bootbox/images/matchbox.tag (1 hunks)
  • packages/system/bucket/images/s3manager.tag (1 hunks)
  • packages/system/capi-providers/templates/providers.yaml (1 hunks)
  • packages/system/cozystack-api/values.yaml (1 hunks)
  • packages/system/cozystack-controller/values.yaml (1 hunks)
  • packages/system/dashboard/charts/kubeapps/templates/dashboard/configmap.yaml (1 hunks)
  • packages/system/dashboard/values.yaml (1 hunks)
  • packages/system/kamaji/values.yaml (1 hunks)
  • packages/system/keycloak-operator/values.yaml (1 hunks)
  • packages/system/kubeovn/values.yaml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 18, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/system/capi-providers/templates/providers.yaml (1)

17-23: Deployment Configuration for Kamaji Provider Added
The new deployment section for the kamaji provider correctly adds a containers array with a manager container enforcing resource limits (cpu: 1024m and memory: 1024Mi). This is a good step for standardizing resource allocation. For enhanced consistency, consider whether you might also want to define resource requests—similar to the keycloak-operator configuration—if your scheduling policies require them.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd90eb2 and 1844e22.

📒 Files selected for processing (2)
  • packages/system/capi-providers/templates/providers.yaml (1 hunks)
  • packages/system/keycloak-operator/values.yaml (1 hunks)
🔇 Additional comments (1)
packages/system/keycloak-operator/values.yaml (1)

1-9: New Resource Configuration for Keycloak-Operator
The added resources block under keycloak-operator correctly defines both limits and requests. The memory limit of 512Mi and the CPU/memory requests (50m and 64Mi respectively) provide a clear and concise resource allocation for the operator. Please ensure these values match your operational requirements and cluster capacity.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 18, 2025
@lllamnyp lllamnyp merged commit bc95159 into main Feb 18, 2025
2 checks passed
@lllamnyp lllamnyp deleted the release/v0.25.2 branch February 18, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants