-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release v0.25.2 #634
Conversation
Caution Review failedThe pull request is closed. WalkthroughThis change updates the commit reference used in the dashboard application's Dockerfile. The Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (17)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/system/capi-providers/templates/providers.yaml (1)
17-23
: Deployment Configuration for Kamaji Provider Added
The newdeployment
section for thekamaji
provider correctly adds a containers array with amanager
container enforcing resource limits (cpu: 1024m
andmemory: 1024Mi
). This is a good step for standardizing resource allocation. For enhanced consistency, consider whether you might also want to define resource requests—similar to the keycloak-operator configuration—if your scheduling policies require them.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/system/capi-providers/templates/providers.yaml
(1 hunks)packages/system/keycloak-operator/values.yaml
(1 hunks)
🔇 Additional comments (1)
packages/system/keycloak-operator/values.yaml (1)
1-9
: New Resource Configuration for Keycloak-Operator
The addedresources
block underkeycloak-operator
correctly defines both limits and requests. The memory limit of512Mi
and the CPU/memory requests (50m
and64Mi
respectively) provide a clear and concise resource allocation for the operator. Please ensure these values match your operational requirements and cluster capacity.
feature/add-more-resources
1844e22
to
0f68db6
Compare
Summary by CodeRabbit
kamaji
provider, including resource limits for CPU and memory.keycloak-operator
, specifying limits and requests for memory and CPU.v0.25.2
, including the dashboard, kubeappsapis, and cozystack images, ensuring users benefit from the latest features and improvements.